Invoking `org-mode' when creating the buffer sets
`buffer-save-without-query' to `t' and `save-some-buffers' will then
unconditionally save the buffer.
So, rather than using `set-buffer-modified-p', set
`buffer-save-without-query' to `nil' after invoking `org-mode' during
buffer creation.
Note that we also add a safety check in ORG-QL-VIEW--LINK-FOLLOW,
because the addition of a call to PROPERTIZE in
ORG-QL-VIEW--HEADER-LINE-FORMAT effectively removes what was
functioning as a safety check there (as CONCAT had been signaling an
error for the unsafe argument, whereas PROPERTIZE, which is called to
apply the new face, does not). We also change the expected error in
the tests accordingly.
Modes like org-indent-mode and org-modern can add text properties to
to-do keywords in Org buffers, and those properties can "bleed over"
when org-element copies those regions into strings. When those
strings are then displayed in an org-ql-view buffer, they can affect
how the keywords appear, e.g. having extra spaces prefixing them,
which breaks alignment. We apply faces to the keywords ourselves, so
we don't need any properties from the source buffer.
Fixes#455.
I don't fully understand why this is the correct fix, because I don't
know where the raw heading text is being linkified (it seems like the
:raw-value property should be the unlinkified text), but this seems to
work correctly now. If it turns out to break something else, we'll
find out and fix it.
Fixes#282.
Reported-by: Jacob Boxerman <https://github.com/jakebox>
Hopefully this does not cause a noticeable performance impact. Maybe
the new org-element caching features in Org will help with that.
Fixes#363.
Reported-by: Gabriele Mongiano <https://github.com/kofm>
It didn't seem that calling custom-save-all was necessary in the past,
but it appears that it is now.
Closes#378.
Reported-by: Pentaquark1 <https://github.com/Pentaquark1>
See, e.g. <https://github.com/magnars/dash.el/pull/375>.
Ultimately I'd prefer to indent with one distinguished argument, but
the noise it causes downstream is likely not worth it. (And,
unfortunately, the indentation of the built-in thread-first and
thread-last forms has changed to be like this as well, which is even
worse, causing 10-11 characters of extra indentation in those forms'
bodies!)
This is a breaking change of sorts in that searches using multiple
sorting methods will have to have the order of the sorters reversed to
get the same result. Unfortunate, but I think it's worth it in the
end, and this is pre-1.0, anyway.
Fixes#143.
This actually only fixes a problem with running the tests, because I
don't have a way to force map-2.1 to be installed into the sandbox, so
the tests on CI always fail. So for now we just use -let* for this.
Fixes#138. Fixes#139. Thanks to Matt Huszagh (@matthuszagh) for
reporting.
This *actually* fixes those issues. The 0.4.7 release is related to
those issues, but those issues actually arose in code added to
0.5-pre.
This makes several changes and fixes and adds test cases for all the
combinations I'm aware of.
See #147. Thanks to @tpeacock19 for patiently reporting these issues.
Squashed commit of the following:
commit d1b396c5654ae3fa8ad03d0d4b2cbde20000fa1a
Author: Adam Porter <adam@alphapapa.net>
Date: Mon Nov 16 02:01:23 2020 -0600
WIP: Fixes
commit 23215a723c4bf6e249c330863e01029166db56c3
Author: Adam Porter <adam@alphapapa.net>
Date: Mon Nov 16 01:34:34 2020 -0600
WIP: Fixes
commit 97b13d09d4d52bb168bfc19fb6f8daf2964f4b6c
Author: Adam Porter <adam@alphapapa.net>
Date: Mon Nov 16 00:46:49 2020 -0600
WIP: Test links too
Everything passes now.
commit 1866a71dbbb6416f7e365c90cadd269765d52b70
Author: Adam Porter <adam@alphapapa.net>
Date: Sun Nov 15 22:22:22 2020 -0600
WIP: Test loading/saving bookmarks
