jiri/org-ql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add: (defface org-ql-view-title) Use in -view--header-line-format

Browse source 
Note that we also add a safety check in ORG-QL-VIEW--LINK-FOLLOW,
because the addition of a call to PROPERTIZE in
ORG-QL-VIEW--HEADER-LINE-FORMAT effectively removes what was
functioning as a safety check there (as CONCAT had been signaling an
error for the unsafe argument, whereas PROPERTIZE, which is called to
apply the new face, does not).  We also change the expected error in
the tests accordingly.
This commit is contained in:
Adam Porter 2024-09-10 22:11:10 -05:00
parent c3519fb4a0
commit 1c8c89f264
4 changed files with 65 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

9
org-ql-view.el
View file

@ -59,6 +59,10 @@
"Face for due dates in `org-ql-view' views."
:group 'org-ql)
(defface org-ql-view-title '((t :weight bold))
"View title in header line."
:group 'org-ql-view)
;;;; Variables
(defvar org-ql-view-buffer-name-prefix "*Org QL View:"
@ -459,7 +463,8 @@ subsequent refreshing of the buffer: `org-ql-view-buffers-files',
If TITLE, prepend it to the header."
(let* ((title (if title
(concat (propertize "View:" 'face 'transient-argument)
title " ")
(propertize title 'face 'org-ql-view-title)
" ")
""))
(query-formatted (when query
(org-ql-view--format-query query)))
@ -645,6 +650,8 @@ purposes of compatibility with changes in Org 9.4."
(stringp buffers-files)
(cl-every #'stringp buffers-files))
(error "CAUTION: Link not opened because unsafe buffers-files parameter detected: %s" buffers-files))
(unless (or (stringp title) (null title))
(error "CAUTION: Link not opened because unsafe title parameter detected: %S" title))
(when (or (listp query)
(string-match (rx bol (0+ space) "(") query))
;; SAFETY: Query is in sexp form: ask for confirmation, because it could contain arbitrary code.