Commit graph

99 commits

Author SHA1 Message Date
Ahmed Shariff
837dd98def
Merge 874d9d70d8 into 4f62ba3bd6 2023-11-11 02:09:27 -07:00
Adam Porter
ee01bcb6e8 Merge: v0.7.3 2023-10-23 18:55:00 -05:00
Adam Porter
09c3591504 Fix: Saving of org-ql-view views
It didn't seem that calling custom-save-all was necessary in the past,
but it appears that it is now.

Closes #378.

Reported-by: Pentaquark1 <https://github.com/Pentaquark1>
2023-10-19 21:50:30 -05:00
Adam Porter
9e72bf6947 Fix: (org-ql-view--format-element) Check habit in source buffer
See #364.
2023-09-27 13:36:47 -05:00
Adam Porter
0e702ecb48 Change: Resolve Org element properties on 9.7+
See #364.
2023-09-27 13:36:47 -05:00
Adam Porter
107fc66d08 Change: (org-ql-view--format-element) Use display-warning 2023-03-10 06:24:03 -06:00
Adam Porter
44679a6c93 Comment: Remove old FIXMEs 2023-03-10 06:23:53 -06:00
Adam Porter
d21da3682b Tidy: Compilation warnings 2023-03-09 03:23:42 -06:00
Adam Porter
2bc327d85f Fix: (org-ql-view--link-store) Error message for test suite
Use format string to prevent `substitute-quotes' from changing the
error string, breaking the test suite when run on CI.

Fixes #317.
2023-03-09 02:45:48 -06:00
Adam Porter
a5fbb5d976 Tidy: Indentation of dash forms
See, e.g. <https://github.com/magnars/dash.el/pull/375>.

Ultimately I'd prefer to indent with one distinguished argument, but
the noise it causes downstream is likely not worth it.  (And,
unfortunately, the indentation of the built-in thread-first and
thread-last forms has changed to be like this as well, which is even
worse, causing 10-11 characters of extra indentation in those forms'
bodies!)
2023-03-09 00:01:32 -06:00
Ahmed Shariff
874d9d70d8 Inform users: repscting a func set to org-ql-view-buffers-files 2022-11-20 23:56:32 -08:00
Ahmed Shariff
4b19e5fb0b Allow mulitple values to be read for org-ql-view-buffers-files
commit d8f29225a3
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Fri Sep 24 15:47:38 2021 -0500

    Abstract buffers-files being flattened to a list of strings

commit 2d49745425
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Fri Sep 17 17:53:21 2021 -0500

    Fix: \w duplicates & func's with buffers/names with expand/contract

commit 576f9d3512
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Thu Sep 16 18:42:32 2021 -0500

    Handling support for functions \w functions using completing-read-multiple

commit cea165192d
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Thu Sep 16 16:49:19 2021 -0500

    Cleaning up functions and improvements for clarity.

commit aa9c6ccdfa
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Wed Sep 15 17:56:19 2021 -0500

    Adding `comma separated` instruction to readme

commit 564d491604
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Mon Sep 13 17:05:14 2021 -0500

    Fixes for using mulitiple values and related test suite improvements

commit ffaebcbcbe
Merge: 788951a 94f9e6f
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Mon Sep 13 13:15:57 2021 -0500

    Merge branch 'master' of https://github.com/alphapapa/org-ql

commit 788951a4a9
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Mon Sep 13 11:01:55 2021 -0500

    Replacing org-ql-view--expand-buffers-files

commit cabf88eea5
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Mon Jul 19 00:19:52 2021 -0500

    removing duplcates when expanding buffers-files

commit b68d836562
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Sun Jul 18 23:49:54 2021 -0500

    Using completing-read-multiple for org-ql-view--complete-buffers-files

commit 06bdfc7a9e
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Sun Jul 4 23:32:08 2021 -0500

    Fn always promts for buffer/files; handle buffer obj and list

    Fn: org-ql-view--complete-buffers-files
    With buffers, org-ql-view--contract-buffers-files return the buffer
    name.
    When org-ql-view-buffers-files is a list, just dumpt it as a string
    and check if completion-read returns the same value, if so return the
    original value of org-ql-view-buffers-files

commit cc6e22dd30
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Sun Jul 4 23:31:31 2021 -0500

    Allow reading buffer names for buffers-or-names

commit 89b84768ad
Author: Ahmed Shariff <ahmed.shariff@live.com>
Date:   Sat Jul 3 21:25:10 2021 -0500

    Test cases for all org-ql-view--*-buffers-files functions

commit 7120b6334d
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Sat Jul 3 02:17:33 2021 -0500

    Refactor of org-ql-view--complete-buffers-files

    Handles the different values `org-ql-view-buffers-files` can hold.
    Use completing-read only if `org-ql-view-buffers-files` is nil or the
    contracted form of `org-ql-view-buffers-files` is a string.

commit 7b990e5275
Author: Ahmed Shariff <shariff.mfa@outlook.com>
Date:   Wed Jun 30 18:01:49 2021 -0500

    Fix for issue with initial-input in org-ql-view--complete-buffers-files
2022-11-20 21:43:22 -08:00
Adam Porter
4f11878b7d Update: Transient macro names
Closes #269.  See https://github.com/magit/transient/issues/192.
Thanks to Jonas Bernoulli (@tarsius).
2022-03-18 10:29:07 -05:00
Akira Komamura
da2bab2552 Fix: Abbreviate file paths in created org-ql bookmarks 2021-09-22 00:59:18 -05:00
Adam Porter
94f9e6f303 Add/Change: reverse sorter, and reverse sorting order
This is a breaking change of sorts in that searches using multiple
sorting methods will have to have the order of the sorters reversed to
get the same result.  Unfortunate, but I think it's worth it in the
end, and this is pre-1.0, anyway.

Fixes #143.
2021-07-12 21:33:24 -05:00
Adam Porter
88151b7f00 Fix: (org-ql-view--complete-sort) Add random method
Such a minor omission, not worth a release or changelog entry.
2021-06-17 18:58:48 -05:00
Adam Porter
7a8e3b2e8e Tidy: Indentation
Due to changes in dash.
2021-06-08 10:56:05 -05:00
Adam Porter
b62896a583 Fix: (org-ql-view.el) Declare org-ql-search function
Even though check-declare doesn't seem to find cl-defun forms, even
though its code appears to look for them...
2020-12-03 12:34:41 -06:00
Adam Porter
6ced616836 Tidy: Docstring, add comment 2020-11-24 12:45:16 -06:00
Adam Porter
8fb6efecc1 Fix: Compile warnings 2020-11-24 11:47:42 -06:00
Adam Porter
57b3eeba49 Merge: org-ql-defpred
Squashed commit of the following:

commit a0ace307b0de3f5e811f042fd9f0b821a0bbc95c
Author: Adam Porter <adam@alphapapa.net>
Date:   Mon Nov 23 01:11:07 2020 -0600

    Docs: Fix TOC

commit bef9f3c9b5b762070445c76ac3c833e51dd893ba
Author: Adam Porter <adam@alphapapa.net>
Date:   Mon Nov 23 01:09:33 2020 -0600

    Docs: (README.org) Add org-ql-defpred

commit ff0257696fe87764e3289e12ddc336377a9a5d01
Author: Adam Porter <adam@alphapapa.net>
Date:   Mon Nov 23 00:52:06 2020 -0600

    Docs: Improve defpred.org

    Thanks to piyo in #emacsconf@freenode.

commit 18d6d73a99c336cd637c99309ee5d150106b73b7
Author: Adam Porter <adam@alphapapa.net>
Date:   Mon Nov 23 00:35:24 2020 -0600

    Docs: Improve custom predicate tutorial

    Closes #155.  Thanks to Merlin Göttlinger (@mgttlinger) for suggesting
    improvements.

commit b8cbe36fb3
Author: Adam Porter <adam@alphapapa.net>
Date:   Mon Nov 23 00:05:52 2020 -0600

    Docs: Add custom predicate tutorial

commit b1008d0c52
Author: Adam Porter <adam@alphapapa.net>
Date:   Sun Nov 22 19:34:16 2020 -0600

    Docs: Update readme

commit 73d4f95cd4
Merge: 9a2719f 148a193
Author: Adam Porter <adam@alphapapa.net>
Date:   Sun Nov 22 19:29:15 2020 -0600

    Merge branch 'wip/0.6-pre' into wip/define-predicate

...
2020-11-23 01:13:03 -06:00
Adam Porter
7f8328a87c Change: (-view--link-follow) Ignore second argument
Hopefully this allows compatibility with Org 9.4, since Org's news
file doesn't say what the second argument is.
2020-11-22 17:25:59 -06:00
Adam Porter
c41cd4be82 Change: (-view--link-open, -view--link-follow) Rename function
For consistency with Org's naming scheme.
2020-11-22 17:25:04 -06:00
Adam Porter
71703def04 Change: Query safety checks
- Variable org-ql-ask-unsafe-queries replaces
  org-ql-view-ask-unsafe-links.
- New function: org-ql--ask-unsafe-query.
- Tests: Improve
2020-11-16 23:52:15 -06:00
Adam Porter
50ba441415 Fix: (org-ql-view-bookmark-handler) Bookmark destructuring
See #147.  Thanks to @tpeacock19 for reporting.
2020-11-16 21:16:09 -06:00
Adam Porter
673edaca11 Fix: (org-ql-view--link-open) Handle Org 9.3 links
Or try to, anyway...
2020-11-16 04:52:45 -06:00
Adam Porter
c07971cd57 Tidy: Use -let* instead of pcase-let* for plists
This actually only fixes a problem with running the tests, because I
don't have a way to force map-2.1 to be installed into the sandbox, so
the tests on CI always fail.  So for now we just use -let* for this.
2020-11-16 03:49:46 -06:00
Adam Porter
7770285002 Fix: (org-ql-view--contract-buffers-files) Non-existent org-directory
Fixes #138.  Fixes #139.  Thanks to Matt Huszagh (@matthuszagh) for
reporting.

This *actually* fixes those issues.  The 0.4.7 release is related to
those issues, but those issues actually arose in code added to
0.5-pre.
2020-11-16 02:41:32 -06:00
Adam Porter
9d86ee9e10 Change/Fix: Bookmark, link storing/loading/safety
This makes several changes and fixes and adds test cases for all the
combinations I'm aware of.

See #147.  Thanks to @tpeacock19 for patiently reporting these issues.

Squashed commit of the following:

commit d1b396c5654ae3fa8ad03d0d4b2cbde20000fa1a
Author: Adam Porter <adam@alphapapa.net>
Date:   Mon Nov 16 02:01:23 2020 -0600

    WIP: Fixes

commit 23215a723c4bf6e249c330863e01029166db56c3
Author: Adam Porter <adam@alphapapa.net>
Date:   Mon Nov 16 01:34:34 2020 -0600

    WIP: Fixes

commit 97b13d09d4d52bb168bfc19fb6f8daf2964f4b6c
Author: Adam Porter <adam@alphapapa.net>
Date:   Mon Nov 16 00:46:49 2020 -0600

    WIP: Test links too

    Everything passes now.

commit 1866a71dbbb6416f7e365c90cadd269765d52b70
Author: Adam Porter <adam@alphapapa.net>
Date:   Sun Nov 15 22:22:22 2020 -0600

    WIP: Test loading/saving bookmarks
2020-11-16 02:02:22 -06:00
Adam Porter
8a1fd14590 Fix: (org-ql-view--link-store) Indirect buffers
Probably the best thing to do, even if it's not "correct" in a sense.
2020-11-14 22:29:53 -06:00
Adam Porter
511edbfff8 Notes: Make ToC after sorting 2020-11-14 20:58:19 -06:00
Adam Porter
5b401cd8b7 Tidy: (org-ql-view-bookmark-make-record) 2020-11-14 20:36:28 -06:00
Adam Porter
0a2b751464 Fix: (org-ql-view-bookmark-make-record) List of filenames
Fixes #148.  Thanks to @tpeacock19 for reporting.
2020-11-14 20:35:52 -06:00
Adam Porter
1b12d4e9b0 Fix: (org-ql-view--link-store) Don't re-format formatted queries
org-ql-view--format-query already returns a string.
2020-11-14 05:43:50 -06:00
Adam Porter
4a8deb541e Comment: Add FIXME 2020-11-14 05:43:12 -06:00
Adam Porter
f63012dd5a Fix: (org-ql-view--link-store) Rejection of unlinkable buffers
Also, remove the Org <=9.1.4 compatibility code.  It's not worth it.
I'm probably the only person who needs it, anyway, and I can live with
the double-call until I upgrade my Org version.

Fixes #148.  Thanks to @tpeacock19 for reporting.
2020-11-12 02:44:16 -06:00
Adam Porter
284eda87e5 Fix: (org-ql-view--link-store) Test Org version
See #147.  Thanks to @tpeacock19 for reporting.
2020-11-12 02:10:57 -06:00
Adam Porter
a5d4886880 Fix: (org-ql-view--link-open) Safety check the sort parameter 2020-11-12 00:22:23 -06:00
Adam Porter
689cfd68e7 Fix: (-view--link-open) Set org-super-agenda-allow-unsafe-groups 2020-11-11 22:52:54 -06:00
Adam Porter
6ab74454d0 Fix: (org-ql-view--expand-buffers-files) Remove eval support
This prevents arbitrary code execution when opening "org-ql-search:"
links.  (The links feature was just pushed to master in the last day
or so, and no stable release with the feature has been tagged.)  This
fix also means that arbitrary expressions are no longer accepted when
interactively completing the buffers-files argument to
org-ql-search (a worthy trade, I think; users who need to do that can
call the function from Lisp).
2020-11-11 20:51:24 -06:00
Adam Porter
2bed84aa1e Fix: (org-ql-view--contract-buffers-files) Don't check file exists
If the buffer has no filename, this will signal an error.
2020-11-11 19:54:13 -06:00
Adam Porter
b0e8fa2734 Tidy: Indentation 2020-11-11 19:52:46 -06:00
Adam Porter
04c94bc141 Change: (org-ql-view.el) Rename bookmark functions
They shouldn't be private functions, especially since one is autoloaded.
2020-11-11 19:52:24 -06:00
Adam Porter
0101bbebde Comment: Remove useless package header
Not the main library file.
2020-11-11 19:52:24 -06:00
Adam Porter
87b952c7bf Fix: (org-ql-view--link-store) Don't store link to buffers 2020-11-11 19:52:24 -06:00
Adam Porter
ef40a25b05 Change: (org-ql-view--link-store) Convert queries to strings
See #147.
2020-11-11 19:52:24 -06:00
Adam Porter
07d21e57c0 Tidy 2020-11-11 19:52:24 -06:00
Adam Porter
bfd4d462a0 Add/Change/Fix: Storing links to containing buffer or files
This feels too complicated, but I don't see a way around it, short of
redesigning all of the argument expansion/contraction, which might end
up in the same place, anyway.

See #147.
2020-11-11 19:52:24 -06:00
Adam Porter
8102d7a8ee Fix: (org-ql-view--format-element)
Actually, really fix it this time.

Fixes #150.  Thanks to @tpeacock19 for reporting.
2020-11-11 18:11:24 -06:00
Adam Porter
168041f0df Comment: Add FIXME 2020-11-11 04:24:34 -06:00