Fixes#138. Fixes#139. Thanks to Matt Huszagh (@matthuszagh) for
reporting.
This *actually* fixes those issues. The 0.4.7 release is related to
those issues, but those issues actually arose in code added to
0.5-pre.
This makes several changes and fixes and adds test cases for all the
combinations I'm aware of.
See #147. Thanks to @tpeacock19 for patiently reporting these issues.
Squashed commit of the following:
commit d1b396c5654ae3fa8ad03d0d4b2cbde20000fa1a
Author: Adam Porter <adam@alphapapa.net>
Date: Mon Nov 16 02:01:23 2020 -0600
WIP: Fixes
commit 23215a723c4bf6e249c330863e01029166db56c3
Author: Adam Porter <adam@alphapapa.net>
Date: Mon Nov 16 01:34:34 2020 -0600
WIP: Fixes
commit 97b13d09d4d52bb168bfc19fb6f8daf2964f4b6c
Author: Adam Porter <adam@alphapapa.net>
Date: Mon Nov 16 00:46:49 2020 -0600
WIP: Test links too
Everything passes now.
commit 1866a71dbbb6416f7e365c90cadd269765d52b70
Author: Adam Porter <adam@alphapapa.net>
Date: Sun Nov 15 22:22:22 2020 -0600
WIP: Test loading/saving bookmarks
Also, remove the Org <=9.1.4 compatibility code. It's not worth it.
I'm probably the only person who needs it, anyway, and I can live with
the double-call until I upgrade my Org version.
Fixes#148. Thanks to @tpeacock19 for reporting.
This prevents arbitrary code execution when opening "org-ql-search:"
links. (The links feature was just pushed to master in the last day
or so, and no stable release with the feature has been tagged.) This
fix also means that arbitrary expressions are no longer accepted when
interactively completing the buffers-files argument to
org-ql-search (a worthy trade, I think; users who need to do that can
call the function from Lisp).
This feels too complicated, but I don't see a way around it, short of
redesigning all of the argument expansion/contraction, which might end
up in the same place, anyway.
See #147.
Use org-ql--tags-at instead of org-get-tags/org-get-tags-at. This
uses our cache, which should improve performance, and it obviates the
function alias for Org versions before 9.3 (which occasionally
misbehaves, e.g. if Org is reloaded).
This is sort of a workaround or preventative measure as much as it is
a fix. It seemed to be necessary when I was testing bookmark
loading in org-sidebar.
If the org-agenda-files variable points to a file pointing to a list
of agenda files, it shouldn't be compared to. We should only compare
to the value returned by the org-agenda-files function.
Fixes#104. Thanks to @gdindi for reporting.
Using a different major mode in org-ql-view buffers causes some Org Agenda
remote commands to not work, because they test whether the major mode
is org-agenda-mode. Even though these remote commands are not
guaranteed to work, it was not intended to break them now, so this
restores compatibility with them.
Fixes#102. Thanks to Alois Janíček (@aloisjanicek) for reporting.
This reverts commit ba7d4a2e82.
Released as 0.4.4.
Use a derived major mode for org-ql-view buffers, and ensure that mode
is active when calling org-ql-view-refresh, to avoid interfering with
buffers in other modes if the user calls the command by accident.
See
<b87156f2bb>.
Thanks to Alois Janíček (@AloisJanicek) for discovering the bug.
Released as 0.4.3.
I keep hitting "g" and nothing seems to happen, because it runs the
org-agenda refresh command, which doesn't do anything in org-ql-view
buffers. This must be happening to other people too. So let's fix
that.
This fixes the bug for now, but it needs to be tested more carefully.
And now the view dispatcher has a minor bug when changing the list of
buffers-files sometimes that requires pressing it more than once to
get the prompt; not sure if related to this.
When offering completion of org-ql-view-buffers-files, and when
formatting it in the header line, use the "contracted" form when
possible (i.e. show "org-agenda-files" instead of a list of all the
expanded agenda file filenames).
Fixes#95. Thanks to Kilian Sprotte (@kisp) for suggesting.
