This feels too complicated, but I don't see a way around it, short of
redesigning all of the argument expansion/contraction, which might end
up in the same place, anyway.
See #147.
Use org-ql--tags-at instead of org-get-tags/org-get-tags-at. This
uses our cache, which should improve performance, and it obviates the
function alias for Org versions before 9.3 (which occasionally
misbehaves, e.g. if Org is reloaded).
This is sort of a workaround or preventative measure as much as it is
a fix. It seemed to be necessary when I was testing bookmark
loading in org-sidebar.
If the org-agenda-files variable points to a file pointing to a list
of agenda files, it shouldn't be compared to. We should only compare
to the value returned by the org-agenda-files function.
Fixes#104. Thanks to @gdindi for reporting.
Using a different major mode in org-ql-view buffers causes some Org Agenda
remote commands to not work, because they test whether the major mode
is org-agenda-mode. Even though these remote commands are not
guaranteed to work, it was not intended to break them now, so this
restores compatibility with them.
Fixes#102. Thanks to Alois Janíček (@aloisjanicek) for reporting.
This reverts commit ba7d4a2e82.
Released as 0.4.4.
Use a derived major mode for org-ql-view buffers, and ensure that mode
is active when calling org-ql-view-refresh, to avoid interfering with
buffers in other modes if the user calls the command by accident.
See
<b87156f2bb>.
Thanks to Alois Janíček (@AloisJanicek) for discovering the bug.
Released as 0.4.3.
I keep hitting "g" and nothing seems to happen, because it runs the
org-agenda refresh command, which doesn't do anything in org-ql-view
buffers. This must be happening to other people too. So let's fix
that.
This fixes the bug for now, but it needs to be tested more carefully.
And now the view dispatcher has a minor bug when changing the list of
buffers-files sometimes that requires pressing it more than once to
get the prompt; not sure if related to this.
When offering completion of org-ql-view-buffers-files, and when
formatting it in the header line, use the "contracted" form when
possible (i.e. show "org-agenda-files" instead of a list of all the
expanded agenda file filenames).
Fixes#95. Thanks to Kilian Sprotte (@kisp) for suggesting.
Even when org-done-keywords-for-agenda is nil. I'm not sure when this
was broken, but the logic was wrong in this function, and this is the
intended behavior, so this is a bug fix.
Released as 0.4.2.
Closes#71. Thanks to @xeijin.
Squashed commit of the following:
commit edac9c6960
Author: Adam Porter <adam@alphapapa.net>
Date: Sat Jan 18 20:24:28 2020 -0600
Adjust message, indentation, add changelog entry
commit 6a263e34ff
Author: xeijin <xeijin@users.noreply.github.com>
Date: Fri Jan 3 19:08:10 2020 +0000
removing view title
commit fc37e3f146
Author: xeijin <xeijin@users.noreply.github.com>
Date: Mon Dec 9 22:47:00 2019 +0000
confirmation message for org-ql-view-refresh
In keeping with the message displayed by `g` when refreshing an
org-agenda buffer - if nothing has changed in an `org-ql` buffer
it can sometimes be difficult to determine if the refresh took
place at all.
Emacs 27 marks map-put as obsolete and renames it to map-put!, which
causes byte-compilation warnings (sigh...isn't that the definition of
useless churn?). Of course, map-put! doesn't exist in Emacs 26, so we
can't just use that. I'm beginning to think that it will never be
possible to make the linting clean.
org-get-todo-face uses org-done-keywords, which is a buffer-local
variable, so it may be nil in the context that
org-ql-view--add-todo-face is called. See,
e.g. org-agenda-highlight-todo, which does the same thing.
Thanks to Yiming Chen (@dsdshcym).
