This makes several changes and fixes and adds test cases for all the
combinations I'm aware of.
See #147. Thanks to @tpeacock19 for patiently reporting these issues.
Squashed commit of the following:
commit d1b396c5654ae3fa8ad03d0d4b2cbde20000fa1a
Author: Adam Porter <adam@alphapapa.net>
Date: Mon Nov 16 02:01:23 2020 -0600
WIP: Fixes
commit 23215a723c4bf6e249c330863e01029166db56c3
Author: Adam Porter <adam@alphapapa.net>
Date: Mon Nov 16 01:34:34 2020 -0600
WIP: Fixes
commit 97b13d09d4d52bb168bfc19fb6f8daf2964f4b6c
Author: Adam Porter <adam@alphapapa.net>
Date: Mon Nov 16 00:46:49 2020 -0600
WIP: Test links too
Everything passes now.
commit 1866a71dbbb6416f7e365c90cadd269765d52b70
Author: Adam Porter <adam@alphapapa.net>
Date: Sun Nov 15 22:22:22 2020 -0600
WIP: Test loading/saving bookmarks
This seems to fix an occasional weird bug encountered when
byte-compiling and loading this file. I can't explain why it only
happens sometimes, but this seems to fix it, and it stands to reason
why it does, so it seems like the right thing to do.
Also, remove the Org <=9.1.4 compatibility code. It's not worth it.
I'm probably the only person who needs it, anyway, and I can live with
the double-call until I upgrade my Org version.
Fixes#148. Thanks to @tpeacock19 for reporting.
This prevents arbitrary code execution when opening "org-ql-search:"
links. (The links feature was just pushed to master in the last day
or so, and no stable release with the feature has been tagged.) This
fix also means that arbitrary expressions are no longer accepted when
interactively completing the buffers-files argument to
org-ql-search (a worthy trade, I think; users who need to do that can
call the function from Lisp).
This feels too complicated, but I don't see a way around it, short of
redesigning all of the argument expansion/contraction, which might end
up in the same place, anyway.
See #147.
