jiri/org-ql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix: (helm-source-org-ql-views) Call helm-make-source directly

Browse source 
Avoids macro expansion issues if Helm is not yet loaded.

Fixes #60.  Thanks to @matthuszagh for reporting.
This commit is contained in:
Adam Porter 2019-11-29 21:08:22 -06:00
parent d3a73732ac
commit d7fe019d6a
3 changed files with 23 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

3
README.org
View file

@ -388,6 +388,9 @@ Expands into a call to ~org-ql-select~ with the same arguments. For convenience
+ Alias =h= for =heading= predicate. + Alias =h= for =heading= predicate.
+ Search/view buffers now always end with a newline, which prevents side-scrolling of the window when calling =end-of-buffer=. + Search/view buffers now always end with a newline, which prevents side-scrolling of the window when calling =end-of-buffer=.
*Fixed*
+ Call =helm-make-source= directly instead of using =helm-build-sync-source= macro. (Fixes [[https://github.com/alphapapa/org-ql/issues/60][#60]]. Thanks to Matt Huszagh ([[https://github.com/matthuszagh][@matthuszagh]]) for reporting.)
*Internal* *Internal*
+ Added generic node data cache to speed up recursive, tree-based queries. + Added generic node data cache to speed up recursive, tree-based queries.

2
helm-org-ql.el
View file

@ -67,7 +67,7 @@
Based on `helm-map'.") Based on `helm-map'.")
(defvar helm-source-org-ql-views (defvar helm-source-org-ql-views
(helm-build-sync-source "Org QL Views" (helm-make-source "Org QL Views" 'helm-source-sync
:candidates (lambda () :candidates (lambda ()
(->> org-ql-views (->> org-ql-views
(-map #'car) (-map #'car)

31
org-ql.info
View file

@ -718,6 +718,13 @@ File: README.info, Node: 04-pre, Next: 032, Up: Changelog
• Search/view buffers now always end with a newline, which prevents • Search/view buffers now always end with a newline, which prevents
side-scrolling of the window when calling end-of-buffer. side-scrolling of the window when calling end-of-buffer.
*Fixed*
• Call helm-make-source directly instead of using
helm-build-sync-source macro. (Fixes #60
(https://github.com/alphapapa/org-ql/issues/60). Thanks to Matt
Huszagh (@matthuszagh (https://github.com/matthuszagh)) for
reporting.)
*Internal* *Internal*
• Added generic node data cache to speed up recursive, tree-based • Added generic node data cache to speed up recursive, tree-based
queries. queries.
@ -1009,18 +1016,18 @@ Node: Agenda-like views18252
Node: Listing / acting-on results19657 Node: Listing / acting-on results19657
Node: Changelog24259 Node: Changelog24259
Node: 04-pre24796 Node: 04-pre24796
Node: 03226057 Node: 03226323
Node: 03126438 Node: 03126704
Node: 0326633 Node: 0326899
Node: 02329606 Node: 02329872
Node: 02229832 Node: 02230098
Node: 02130098 Node: 02130364
Node: 0230295 Node: 0230561
Node: 0134328 Node: 0134594
Node: Notes34427 Node: Notes34693
Node: Comparison with Org Agenda searches34589 Node: Comparison with Org Agenda searches34855
Node: org-sidebar35460 Node: org-sidebar35726
Node: License35739 Node: License36005
 
End Tag Table End Tag Table