jiri/org-ql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change/Tidy: (-agenda--format-element) Remove no-marker warning

Browse source 
And update to-dos.
This commit is contained in:
Adam Porter 2019-08-31 23:33:11 -05:00
parent ad9de23987
commit a34d5f77bd
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
org-ql-agenda.el
View file

@ -485,19 +485,19 @@ return an empty string."
(org-link-display-format it))) (org-link-display-format it)))
(todo-keyword (-some--> (org-element-property :todo-keyword element) (todo-keyword (-some--> (org-element-property :todo-keyword element)
(org-ql-agenda--add-todo-face it))) (org-ql-agenda--add-todo-face it)))
;; FIXME: Figure out whether I should use `org-agenda-use-tag-inheritance' or `org-use-tag-inheritance', etc. ;; TODO: Figure out whether I should use `org-agenda-use-tag-inheritance' or `org-use-tag-inheritance', etc.
(tag-list (if org-use-tag-inheritance (tag-list (if org-use-tag-inheritance
;; FIXME: Note that tag inheritance cannot be used here unless markers are ;; NOTE: Tag inheritance cannot be used here unless markers are added, otherwise
;; added, otherwise we can't go to the item's buffer to look for inherited ;; we can't go to the item's buffer to look for inherited tags. (Or does
;; tags. (Or does `org-element-headline-parser' parse inherited tags too? I ;; `org-element-headline-parser' parse inherited tags too? I forget...)
;; forget...)
(if-let ((marker (or (org-element-property :org-hd-marker element) (if-let ((marker (or (org-element-property :org-hd-marker element)
(org-element-property :org-marker element)))) (org-element-property :org-marker element))))
(with-current-buffer (marker-buffer marker) (with-current-buffer (marker-buffer marker)
;; I wish `org-get-tags' used the correct buffer automatically. ;; I wish `org-get-tags' used the correct buffer automatically.
(org-get-tags marker (not org-use-tag-inheritance))) (org-get-tags marker (not org-use-tag-inheritance)))
;; No marker found ;; No marker found.
(warn "No marker found for item: %s" title) ;; MAYBE: Issue some kind of warning when no marker is found, because it's
;; likely a mistake. But we don't want to be annoying in case it's intentional.
(org-element-property :tags element)) (org-element-property :tags element))
(org-element-property :tags element))) (org-element-property :tags element)))
(tag-string (when tag-list (tag-string (when tag-list