jiri/org-ql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix: (org-ql-view--link-store) Indirect buffers

Browse source 
Probably the best thing to do, even if it's not "correct" in a sense.
This commit is contained in:
Adam Porter 2020-11-14 22:29:53 -06:00
parent dabb812a3c
commit 8a1fd14590
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
org-ql-view.el
View file

@ -662,10 +662,15 @@ When opened, the link searches the buffer it's opened from."
("containing file" nil) ("containing file" nil)
(buffers-files (prin1-to-string buffers-files)))) (buffers-files (prin1-to-string buffers-files))))
(string-or-file-buffer-p (string-or-file-buffer-p
(thing) (cl-typecase thing (thing) (cl-etypecase thing
(string thing) (string thing)
(buffer (or (buffer-file-name thing) (buffer (or (buffer-file-name thing)
(buffer-file-name (buffer-base-buffer thing))))))) ;; TODO: Should indirect buffers be allowed? Maybe not, since their narrowing isn't preserved.
;; On the other hand, it's possible to accidentally make a search view for an indirect buffer
;; that's since been widened, and forcing the user to manually change that would be awkward,
;; and trying to communicate the problem would be difficult, so maybe it's okay to allow it.
(when (buffer-base-buffer thing)
(buffer-file-name (buffer-base-buffer thing))))))))
(unless (or (string-or-file-buffer-p org-ql-view-buffers-files) (unless (or (string-or-file-buffer-p org-ql-view-buffers-files)
(and (listp org-ql-view-buffers-files) (and (listp org-ql-view-buffers-files)
(cl-every #'string-or-file-buffer-p org-ql-view-buffers-files))) (cl-every #'string-or-file-buffer-p org-ql-view-buffers-files)))