jiri/org-ql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Comment: Add FIXMEs

Browse source
This commit is contained in:
Adam Porter 2020-11-11 00:21:56 -06:00
parent 78fd672cc7
commit 73da48d9da
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
org-ql.el
View file

@ -393,6 +393,7 @@ If NARROW is non-nil, buffer will not be widened."
;;;;; Helpers ;;;;; Helpers
(defun org-ql--tags-at (position) (defun org-ql--tags-at (position)
;; FIXME: This function actually assumes that point is already at POSITION.
"Return tags for POSITION in current buffer. "Return tags for POSITION in current buffer.
Returns cons (INHERITED-TAGS . LOCAL-TAGS)." Returns cons (INHERITED-TAGS . LOCAL-TAGS)."
;; I'd like to use `-if-let*', but it doesn't leave non-nil variables ;; I'd like to use `-if-let*', but it doesn't leave non-nil variables
@ -404,6 +405,9 @@ Returns cons (INHERITED-TAGS . LOCAL-TAGS)."
(buffer-unmodified-p (eq (buffer-modified-tick) modified-tick)) (buffer-unmodified-p (eq (buffer-modified-tick) modified-tick))
(cached-result (gethash position tags-cache))) (cached-result (gethash position tags-cache)))
;; Found in cache: return them. ;; Found in cache: return them.
;; FIXME: Isn't `cached-result' a list of (INHERITED . LOCAL)? It
;; will never be just `org-ql-nil', but the CAR and CDR may be, so
;; they need to each be checked and replaced with nil if necessary.
(pcase cached-result (pcase cached-result
('org-ql-nil nil) ('org-ql-nil nil)
(_ cached-result)) (_ cached-result))