Fix: (org-ql-view--format-element) Avoid unlinkifying links

I don't fully understand why this is the correct fix, because I don't
know where the raw heading text is being linkified (it seems like the
:raw-value property should be the unlinkified text), but this seems to
work correctly now.  If it turns out to break something else, we'll
find out and fix it.

Fixes #282.

Reported-by: Jacob Boxerman <https://github.com/jakebox>
This commit is contained in:
Adam Porter 2024-01-03 18:32:02 -06:00
parent 8e9a8fe090
commit 529e05851b
3 changed files with 41 additions and 37 deletions

View file

@ -558,6 +558,7 @@ Simple links may also be written manually in either sexp or non-sexp form, like:
*Fixes* *Fixes*
+ Command ~org-ql-find~ widens the buffer before going to the selected entry. + Command ~org-ql-find~ widens the buffer before going to the selected entry.
+ In ~org-ql-view~ buffers, links in headings remain clickable links. (Fixes [[https://github.com/alphapapa/org-ql/issues/282][#282]]. Thanks to [[https://github.com/jakebox][Jacob Boxerman]] for reporting.)
** 0.8 ** 0.8

View file

@ -869,8 +869,7 @@ return an empty string."
;; Adding the relative due date property should probably be done explicitly and separately ;; Adding the relative due date property should probably be done explicitly and separately
;; (which would also make it easier to do it independently of faces, etc). ;; (which would also make it easier to do it independently of faces, etc).
(title (--> (org-ql-view--add-faces element) (title (--> (org-ql-view--add-faces element)
(org-element-property :raw-value it) (org-element-property :raw-value it)))
(org-link-display-format it)))
(todo-keyword (-some--> (org-element-property :todo-keyword element) (todo-keyword (-some--> (org-element-property :todo-keyword element)
(org-ql-view--add-todo-face it))) (org-ql-view--add-todo-face it)))
(tag-list (if org-use-tag-inheritance (tag-list (if org-use-tag-inheritance

View file

@ -1072,6 +1072,10 @@ File: README.info, Node: 081-pre, Next: 08, Up: Changelog
• Command org-ql-find widens the buffer before going to the • Command org-ql-find widens the buffer before going to the
selected entry. selected entry.
• In org-ql-view buffers, links in headings remain clickable links.
(Fixes #282 (https://github.com/alphapapa/org-ql/issues/282).
Thanks to Jacob Boxerman (https://github.com/jakebox) for
reporting.)
 
File: README.info, Node: 08, Next: 074, Prev: 081-pre, Up: Changelog File: README.info, Node: 08, Next: 074, Prev: 081-pre, Up: Changelog
@ -1919,41 +1923,41 @@ Node: Links38827
Node: Tips39514 Node: Tips39514
Node: Changelog39838 Node: Changelog39838
Node: 081-pre40676 Node: 081-pre40676
Node: 0840871 Node: 0841097
Node: 07443599 Node: 07443825
Node: 07343822 Node: 07344048
Node: 07244554 Node: 07244780
Node: 07145473 Node: 07145699
Node: 0746282 Node: 0746508
Node: 06349206 Node: 06349432
Node: 06249737 Node: 06249963
Node: 06150042 Node: 06150268
Node: 0650612 Node: 0650838
Node: 05253668 Node: 05253894
Node: 05153970 Node: 05154196
Node: 0554395 Node: 0554621
Node: 04955926 Node: 04956152
Node: 04856208 Node: 04856434
Node: 04756557 Node: 04756783
Node: 04656966 Node: 04657192
Node: 04557374 Node: 04557600
Node: 04457735 Node: 04457961
Node: 04358094 Node: 04358320
Node: 04258297 Node: 04258523
Node: 04158458 Node: 04158684
Node: 0458705 Node: 0458931
Node: 03262806 Node: 03263032
Node: 03163209 Node: 03163435
Node: 0363406 Node: 0363632
Node: 02366706 Node: 02366932
Node: 02266940 Node: 02267166
Node: 02167220 Node: 02167446
Node: 0267425 Node: 0267651
Node: 0171503 Node: 0171729
Node: Notes71604 Node: Notes71830
Node: Comparison with Org Agenda searches71766 Node: Comparison with Org Agenda searches71992
Node: org-sidebar72655 Node: org-sidebar72881
Node: License72934 Node: License73160
 
End Tag Table End Tag Table