if `sort' is not a list, existing code will always return true

This commit is contained in:
Jeff Filipovits 2020-01-07 08:02:50 -05:00
parent fa1e3354b6
commit 4256e89ff4

View file

@ -242,7 +242,7 @@ returns nil or non-nil."
(pcase sort (pcase sort
(`nil items) (`nil items)
((or 'date 'deadline 'scheduled 'todo 'priority 'random ((or 'date 'deadline 'scheduled 'todo 'priority 'random
(guard (cl-loop for elem in sort (guard (cl-loop for elem in (-list sort)
always (memq elem '(date deadline scheduled todo priority random))))) always (memq elem '(date deadline scheduled todo priority random)))))
;; Default sorting functions ;; Default sorting functions
(org-ql--sort-by items (-list sort))) (org-ql--sort-by items (-list sort)))