Fix: (org-ql-completing-read) Binding of completion-styles-alist

Fixes #337.

Thanks to Nicholas Vollmer (@progfolio), viz (@9viz), and Karthik
Chikmagalur (@karthink) for reporting and suggesting fixes.
This commit is contained in:
Adam Porter 2024-08-29 14:39:55 -05:00
parent 357d533b75
commit 3c1dd36990
3 changed files with 52 additions and 43 deletions

View file

@ -557,6 +557,7 @@ Simple links may also be written manually in either sexp or non-sexp form, like:
*Fixes*
+ Remove text properties from to-do keywords before displaying them in an ~org-ql-view~ buffer. (Such text properties could cause them to, e.g. display with extra leading spaces, depending on which other modes might be enabled in the source Org buffer.)
+ Binding of ~completion-styles-alist~ in ~org-ql-completing-read~. (This fixes compatibility with Helm's ~helm~ completion style, as well as default Emacs completion in recursive minibuffers. [[https://github.com/alphapapa/org-ql/issues/337][#337]]. Thanks to [[https://github.com/progfolio][Nicholas Vollmer]], [[https://github.com/9viz][viz]], and [[https://github.com/karthink][Karthik Chikmagalur]] for reporting and suggesting fixes.)
** 0.8.7

View file

@ -335,7 +335,8 @@ single predicate)."
;; `completing-read'.
(mapc #'org-ql--ensure-buffer buffers-files)
(let* ((completion-styles '(org-ql-completing-read))
(completion-styles-alist (list (list 'org-ql-completing-read #'try #'all "Org QL Find")))
(completion-styles-alist (cons (list 'org-ql-completing-read #'try #'all "Org QL Find")
completion-styles-alist))
(selected
(minibuffer-with-setup-hook
(lambda ()

View file

@ -1087,6 +1087,13 @@ File: README.info, Node: 088-pre, Next: 087, Up: Changelog
in an org-ql-view buffer. (Such text properties could cause them
to, e.g. display with extra leading spaces, depending on which
other modes might be enabled in the source Org buffer.)
• Binding of completion-styles-alist in org-ql-completing-read.
(This fixes compatibility with Helms helm completion style, as
well as default Emacs completion in recursive minibuffers. #337
(https://github.com/alphapapa/org-ql/issues/337). Thanks to
Nicholas Vollmer (https://github.com/progfolio), viz
(https://github.com/9viz), and Karthik Chikmagalur
(https://github.com/karthink) for reporting and suggesting fixes.)

File: README.info, Node: 087, Next: 086, Prev: 088-pre, Up: Changelog
@ -2044,48 +2051,48 @@ Node: Links38925
Node: Tips39612
Node: Changelog39936
Node: 088-pre40872
Node: 08741255
Node: 08642487
Node: 08542721
Node: 08443377
Node: 08343829
Node: 08244170
Node: 08144563
Node: 0844984
Node: 07447708
Node: 07347933
Node: 07248667
Node: 07149588
Node: 0750399
Node: 06353265
Node: 06253798
Node: 06154105
Node: 0654675
Node: 05257731
Node: 05158033
Node: 0558458
Node: 04959989
Node: 04860271
Node: 04760620
Node: 04661029
Node: 04561437
Node: 04461798
Node: 04362157
Node: 04262360
Node: 04162521
Node: 0462768
Node: 03266869
Node: 03167272
Node: 0367469
Node: 02370769
Node: 02271003
Node: 02171283
Node: 0271488
Node: 0175566
Node: Notes75667
Node: Comparison with Org Agenda searches75829
Node: org-sidebar76718
Node: License76997
Node: 08741735
Node: 08642967
Node: 08543201
Node: 08443857
Node: 08344309
Node: 08244650
Node: 08145043
Node: 0845464
Node: 07448188
Node: 07348413
Node: 07249147
Node: 07150068
Node: 0750879
Node: 06353745
Node: 06254278
Node: 06154585
Node: 0655155
Node: 05258211
Node: 05158513
Node: 0558938
Node: 04960469
Node: 04860751
Node: 04761100
Node: 04661509
Node: 04561917
Node: 04462278
Node: 04362637
Node: 04262840
Node: 04163001
Node: 0463248
Node: 03267349
Node: 03167752
Node: 0367949
Node: 02371249
Node: 02271483
Node: 02171763
Node: 0271968
Node: 0176046
Node: Notes76147
Node: Comparison with Org Agenda searches76309
Node: org-sidebar77198
Node: License77477

End Tag Table