jiri/org-ql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix: Unused variable warnings

Browse source 
We may need these in the future, so rather than have to dig these back
out of org-agenda.el, I'll just comment them out for now.  This
silences the byte-compiler.
This commit is contained in:
Adam Porter 2018-08-22 14:29:00 -05:00
parent e141089633
commit 103993c52e
1 changed files with 40 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

76
org-ql-agenda.el
View file

@ -162,9 +162,9 @@ Its property list should be the second item in the list, as returned by `org-ele
;; better to avoid this somehow. At least, we should use a ;; better to avoid this somehow. At least, we should use a
;; function to convert plists to alists, if possible. ;; function to convert plists to alists, if possible.
(properties (cl-loop for (key val) on properties by #'cddr (properties (cl-loop for (key val) on properties by #'cddr
for key = (intern (cl-subseq (symbol-name key) 1)) for symbol = (intern (cl-subseq (symbol-name key) 1))
unless (member key '(parent)) unless (member symbol '(parent))
append (list key val))) append (list symbol val)))
;; TODO: --add-faces is used to add the :relative-due-date property, but that fact is ;; TODO: --add-faces is used to add the :relative-due-date property, but that fact is
;; hidden by doing it through --add-faces (which calls --add-scheduled-face and ;; hidden by doing it through --add-faces (which calls --add-scheduled-face and
;; --add-deadline-face), and doing it in this form that gets the title hides it even more. ;; --add-deadline-face), and doing it in this form that gets the title hides it even more.
@ -195,8 +195,7 @@ Its property list should be the second item in the list, as returned by `org-ele
(s-join ":" it) (s-join ":" it)
(s-wrap it ":") (s-wrap it ":")
(org-add-props it nil 'face 'org-tag))) (org-add-props it nil 'face 'org-tag)))
(level (org-element-property :level element)) ;; (category (org-element-property :category element))
(category (org-element-property :category element))
(priority-string (-some->> (org-element-property :priority element) (priority-string (-some->> (org-element-property :priority element)
(char-to-string) (char-to-string)
(format "[#%s]") (format "[#%s]")
@ -234,40 +233,45 @@ Its property list should be the second item in the list, as returned by `org-ele
;; NOTE: Also adding prefix ;; NOTE: Also adding prefix
(if-let ((scheduled-date (org-element-property :scheduled element))) (if-let ((scheduled-date (org-element-property :scheduled element)))
(let* ((todo-keyword (org-element-property :todo-keyword element)) (let* ((todo-keyword (org-element-property :todo-keyword element))
(show-all (or (eq org-agenda-repeating-timestamp-show-all t)
(member todo-keyword org-agenda-repeating-timestamp-show-all)))
(raw-value (org-element-property :raw-value scheduled-date))
(sexp-p (string-prefix-p "%%" raw-value))
(today-day-number (org-today)) (today-day-number (org-today))
(current-day-number ;; (current-day-number
;; FIXME: This is supposed to be the, shall we say, ;; NOTE: Not currently used, but if we ever implement a more "traditional" agenda that
;; pretend, or perspective, day number that this pass ;; shows perspective of multiple days at once, we'll need this, so I'll leave it for now.
;; through the agenda is being made for. We need to ;; ;; FIXME: This is supposed to be the, shall we say,
;; either set this in the calling function, set it here, ;; ;; pretend, or perspective, day number that this pass
;; or accomplish this in a different way. See ;; ;; through the agenda is being made for. We need to
;; `org-agenda-get-scheduled' and where `date' is set in ;; ;; either set this in the calling function, set it here,
;; `org-agenda-list'. ;; ;; or accomplish this in a different way. See
today-day-number) ;; ;; `org-agenda-get-scheduled' and where `date' is set in
;; ;; `org-agenda-list'.
;; today-day-number)
(scheduled-day-number (org-time-string-to-absolute (scheduled-day-number (org-time-string-to-absolute
(org-element-timestamp-interpreter scheduled-date 'ignore))) (org-element-timestamp-interpreter scheduled-date 'ignore)))
(difference-days (- today-day-number scheduled-day-number)) (difference-days (- today-day-number scheduled-day-number))
(relative-due-date (org-add-props (org-ql-agenda--format-relative-date difference-days) nil (relative-due-date (org-add-props (org-ql-agenda--format-relative-date difference-days) nil
'help-echo (org-element-property :raw-value scheduled-date))) 'help-echo (org-element-property :raw-value scheduled-date)))
(repeat-day-number (cond (sexp-p (org-time-string-to-absolute scheduled-date)) ;; FIXME: Unused for now:
((< today-day-number scheduled-day-number) scheduled-day-number) ;; (show-all (or (eq org-agenda-repeating-timestamp-show-all t)
(t (org-time-string-to-absolute ;; (member todo-keyword org-agenda-repeating-timestamp-show-all)))
raw-value ;; FIXME: Unused for now: (sexp-p (string-prefix-p "%%" raw-value))
(if show-all ;; FIXME: Unused for now: (raw-value (org-element-property :raw-value scheduled-date))
current-day-number ;; FIXME: I don't remember what `repeat-day-number' was for, but we aren't using it.
today-day-number) ;; But I'll leave it here for now.
'future ;; (repeat-day-number (cond (sexp-p (org-time-string-to-absolute scheduled-date))
;; FIXME: I don't like ;; ((< today-day-number scheduled-day-number) scheduled-day-number)
;; calling `current-buffer' ;; (t (org-time-string-to-absolute
;; here. If the element has ;; raw-value
;; a marker, we should use ;; (if show-all
;; that. ;; current-day-number
(current-buffer) ;; today-day-number)
(org-element-property :begin element))))) ;; 'future
;; ;; FIXME: I don't like
;; ;; calling `current-buffer'
;; ;; here. If the element has
;; ;; a marker, we should use
;; ;; that.
;; (current-buffer)
;; (org-element-property :begin element)))))
(face (cond ((member todo-keyword org-done-keywords) 'org-agenda-done) (face (cond ((member todo-keyword org-done-keywords) 'org-agenda-done)
((= today-day-number scheduled-day-number) 'org-scheduled-today) ((= today-day-number scheduled-day-number) 'org-scheduled-today)
((> today-day-number scheduled-day-number) 'org-scheduled-previously) ((> today-day-number scheduled-day-number) 'org-scheduled-previously)
@ -294,9 +298,9 @@ property."
(difference-days (- today-day-number deadline-day-number)) (difference-days (- today-day-number deadline-day-number))
(relative-due-date (org-add-props (org-ql-agenda--format-relative-date difference-days) nil (relative-due-date (org-add-props (org-ql-agenda--format-relative-date difference-days) nil
'help-echo (org-element-property :raw-value deadline-date))) 'help-echo (org-element-property :raw-value deadline-date)))
(todo-keyword (org-element-property :todo-keyword element)) ;; FIXME: Unused for now: (todo-keyword (org-element-property :todo-keyword element))
(done-p (member todo-keyword org-done-keywords)) ;; FIXME: Unused for now: (done-p (member todo-keyword org-done-keywords))
(today-p (= today-day-number deadline-day-number)) ;; FIXME: Unused for now: (today-p (= today-day-number deadline-day-number))
(deadline-passed-fraction (--> (- deadline-day-number today-day-number) (deadline-passed-fraction (--> (- deadline-day-number today-day-number)
(float it) (float it)
(/ it (max org-deadline-warning-days 1)) (/ it (max org-deadline-warning-days 1))