jiri/org-ql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix: (--value-at) On cache miss, return nil when function does

Browse source 
Previously, on a cache miss, if FN returned nil, the sentinel would be
returned instead of nil.

Closes #78.  Thanks to Josh Moller-Mara (@mm--) for reporting.
This commit is contained in:
Adam Porter 2019-12-21 16:28:51 -06:00
parent b9dfd7d93b
commit 091a732a88
2 changed files with 44 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/test-org-ql.el
View file

@ -143,6 +143,7 @@ RESULTS should be a list of strings as returned by
sum 1)))))
(describe "Caching"
(it "Clears value cache after buffer changes"
;; See <https://github.com/alphapapa/org-ql/issues/59>.
(with-temp-buffer
@ -159,7 +160,17 @@ RESULTS should be a list of strings as returned by
(goto-char (point-min))
(org-ql--value-at (point-min) #'point)
(expect (org-ql--value-at (point-min) #'org-get-heading)
:to-equal "Heading 2"))))
:to-equal "Heading 2")))
(it "Returns nil when cache misses and function returns nil"
;; See <https://github.com/alphapapa/org-ql/pull/78>.
(with-temp-buffer
(org-mode)
(insert "* Heading 1")
;; FIXME: `--value-at' does not actually move point, so we do it here.
(goto-char (point-min))
(expect (org-ql--value-at (point-min) #'org-get-local-tags)
:to-be nil))))
(describe "Query functions/macros"