jiri/org-ql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix: (org-ql--defpred) Add to predicates variable when compiling

Browse source 
This seems to fix an occasional weird bug encountered when
byte-compiling and loading this file.  I can't explain why it only
happens sometimes, but this seems to fix it, and it stands to reason
why it does, so it seems like the right thing to do.
This commit is contained in:
Adam Porter 2020-11-14 05:41:37 -06:00
parent 89ff02a150
commit 0365b785cc
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
org-ql.el
View file

@ -159,7 +159,11 @@ match."
(fn-name (intern (concat "org-ql--predicate-" (symbol-name name))))
(pred-name (intern (symbol-name name))))
`(progn
(push (list :name ',pred-name :aliases ',aliases :fn ',fn-name :docstring ,docstring :args ',args) org-ql-predicates)
(cl-eval-when (compile load eval)
;; When compiling, the predicate must be added to `org-ql-predicates' before `org-ql--def-plain-query-fn'
;; is called to define `org-ql--plain-query'. Otherwise, `org-ql--plain-query' seems to work properly
;; when interpreted but not always when the file is byte-compiled.
(push (list :name ',pred-name :aliases ',aliases :fn ',fn-name :docstring ,docstring :args ',args) org-ql-predicates))
(cl-defun ,fn-name ,args ,docstring ,@body))))
;; TODO: Mark as obsolete/deprecated.